Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores: Rename SNITCH_LOG to BANSHEE_LOG #15

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chores: Rename SNITCH_LOG to BANSHEE_LOG #15

merged 1 commit into from
Feb 23, 2024

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Feb 4, 2024

closes #4

SamuelRiedel
SamuelRiedel requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. You will also have to change the banshee sourcecode to look for BANSHEE_LOG instead of SNITCH_LOG now to make the changes work. Can you please add this change as well?

@howjmay howjmay requested a review from SamuelRiedel February 21, 2024 16:58
SamuelRiedel
SamuelRiedel approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SamuelRiedel SamuelRiedel merged commit cb45f43 into pulp-platform:main Feb 23, 2024
2 checks passed
@howjmay howjmay deleted the rename branch February 23, 2024 17:37
@howjmay
Copy link
Contributor Author

howjmay commented Feb 23, 2024

Thank you too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelRiedel SamuelRiedel SamuelRiedel approved these changes

@viv-eth viv-eth Awaiting requested review from viv-eth viv-eth is a code owner

@paulsc96 paulsc96 Awaiting requested review from paulsc96 paulsc96 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename SNITCH_LOG to BANSHEE_LOG
2 participants
@howjmay @SamuelRiedel